Repository navigation
fix(release): execute publish instead of passing shell operators to build - #77
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release job reported success but never ran Changesets publish: the action parses
publish-scriptas an executable and arguments, so&& pnpm releasewas passed to the build command as literal arguments. No Changesets output report was generated.Move the npm build into its own workflow step and give the action one executable command,
pnpm run release. Changesets v3 receives the action-providedCHANGESETS_OUTPUTautomatically and writes the report used for release/tag creation.Validation: a real read-only publish plan is empty; executing the exact release command locally with
CHANGESETS_OUTPUTconfirms Changesets runs, reports no unpublished packages, and creates the output file. Diff checks pass. No version bump or new npm release is introduced. The previous main head passed all 12 CI jobs; this PR also runs the full matrix before merge.