fix(runtime): null-initialize Runtime::isolate_

[adrian-niculescu]

Runtime::isolate_ is only assigned near the end of Init, after the context and its bindings are set up, so between construction and that point it holds an indeterminate value. ~Runtime and GetIsolate() read it unconditionally, and currentRuntime_ already points at the runtime from the constructor on, so anything that reaches the runtime before Init finishes gets garbage rather than null.

This initializes it to nullptr, the same way napiEnv_ next to it already is. No change for a runtime that completed Init.

Summary by CodeRabbit

• Bug Fixes
  • Improved runtime stability by ensuring internal state is safely initialized before use.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 84f12433-cbba-4169-815b-b42aa0e91084

📥 Commits

Reviewing files that changed from the base of the PR and between 686157b and c3f83a8.

📒 Files selected for processing (1)

• NativeScript/runtime/Runtime.h

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The Runtime class now initializes isolate_ to nullptr at declaration. This prevents the member from remaining uninitialized before CreateIsolate assigns it.

Changes

Runtime initialization

Layer / File(s)	Summary
Initialize isolate pointer NativeScript/runtime/Runtime.h	Runtime::isolate_ now defaults to nullptr at declaration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c3f83

This localized lifecycle-safety fix gives Runtime::isolate_ a defined null state before initialization without changing behavior after successful setup. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: edusperoni, nathanwalker

Poem

A rabbit checks the runtime's gate

The isolate waits in a safe state
Null before the engines start
A tidy pointer does its part
Hop by hop, the code is clear
No stray values hiding here

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: initializing Runtime::isolate_ to nullptr.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}