Conversation
Contributor
✅ OSS Checks PassedAll tracked OSS checks passed in this run.
Results from commit c087eca, view the full job summary |
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Maven publishing is not performed, GHCR image paths are malformed, and the vulnerability scan no longer blocks releases.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Updates release automation for Maven and GHCR publishing.
Changes:
- Reorganizes release publishing jobs.
- Updates GHCR image build, tagging, and push commands.
- Adjusts workflow permissions and Trivy behavior.
| File | Description |
|---|---|
.github/workflows/release.yaml |
Coordinates Maven and container releases. |
.github/workflows/docker-ghcr.yml |
Builds, scans, tags, and pushes the GHCR image. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Build Server Image | ||
| run: docker build --no-cache --build-arg JAR_NAME="management-node-${{ inputs.jar_version }}" -t "${REPO}:staged" -f "${{ github.workspace }}/docker/Dockerfile" --target ${{ inputs.docker_target }} . | ||
| run: docker build --no-cache --build-arg JAR_NAME="management-node-${{ inputs.jar_version }}" -t ghcr.io/${REPO}/management-node:staged -f "${{ github.workspace }}/docker/Dockerfile" --target ${{ inputs.docker_target }} . |
| - name: Build packages | ||
| run: ./mvnw $MAVEN_CLI_OPTS package -DskipTests | ||
| - name: Publish package | ||
| run: ./mvnw $MAVEN_CLI_OPTS package -DskipTests |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert the release.yml and ghcr code back to what was in main branch