Repository navigation
fix(schematics): resolve and quote paths correctly on Windows - #240
Merged
Merged
Conversation
MartinFillon
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes schematic execution on Windows by correcting module-path conversion and command-line quoting.
problem :
import.meta.resolve-> generatesfiles:///on windows vsfiles://on linux that skewed the following parsing causing an error.fix :
use fileURLToPath to let node handle the path
problem :
this
'${getModulePath(this.collection + "/collection.json")}:${name}'cmd breaks with single quotes somehow
fix :
use double quotes
How do you test this PR?
use pnpm run new on windows