Skip to content

Add NGC Catalog links - #1314

Merged
rusty1s merged 18 commits into
mainfrom
link_ngc_catalog
Oct 30, 2026
Merged

rusty1s merged 18 commits into
mainfrom
link_ngc_catalog

Conversation

@rusty1s

@rusty1s rusty1s commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 7c25121 and 47d0301.

Files selected for processing: 1
  • docs/source/nim.md

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Documentation
    • Clarified the distinction between NVIDIA Build deployment links and NGC container catalog links in the “From SDM to NIM” table.

The NIM model table now has separate NVIDIA Build deployment and NGC Catalog columns. The model IDs and model classes remain unchanged.

Changes: NIM catalog links

Layer / File(s) Summary
NIM deployment and catalog links
docs/source/nim.md
The model table now links each model to its NVIDIA Build deployment page and its NGC container catalog page.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Merge Risk: Minimal · up to 47d03

The documentation-only table change is mergeable.

Pre-merge checks: Passed 4 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Description check Inconclusive No pull request description was provided, so its relevance to the documentation change cannot be assessed. Add a brief description that explains how the documentation now separates NVIDIA Build deployment links from NGC container catalog links.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: adding NGC Catalog links to the documentation.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (7c25121) to head (47d0301).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1314   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         186      186           
  Lines       11813    11813           
=======================================
  Hits         9737     9737           
  Misses       2076     2076           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@rusty1s
rusty1s merged commit f5bd769 into main Oct 30, 2026
10 checks passed
@rusty1s
rusty1s deleted the link_ngc_catalog branch October 30, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant