fix(core): reject mismatched UUID in register() even under -O - #2704
Open
waterWang wants to merge 1 commit into
Open
fix(core): reject mismatched UUID in register() even under -O#2704waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…#2697) DeviceMemoryResource.register() and PinnedMemoryResource.register() validated the supplied UUID against the resource's own with a bare `assert`, which CPython removes under `-O`. A mismatched UUID was then accepted, registered as a foreign registry key, and rewritten into the resource's own UUID, silently corrupting the IPC registry. Replace the assertion with an explicit ValueError so the check is enforced regardless of the interpreter's assertion mode, and convert the internal register() result check in MP_from_allocation_handle to an explicit RuntimeError as well. Signed-off-by: waterWang <waterWang@users.noreply.github.com>
Contributor
github-actions
Bot
added
the
cuda.core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2697
DeviceMemoryResource.register()andPinnedMemoryResource.register()validated the supplied UUID against the resource's own with a bare
assertinMP_register(cuda_core/cuda/core/_memory/_ipc.pyx).Since CPython strips assertions when run with
-O, the check silentlydisappears in optimized interpreters: the resource is registered under
a foreign key and its own UUID is rewritten to the attacker-
controlled value (
mr.uuidreports the new value from then on).Changes
_ipc.pyxMP_register: replaceassert self.uuid is None or self.uuid == uuidwith an explicitValueErrorwhen the suppliedUUID does not match the resource's own.
_ipc.pyxMP_from_allocation_handle: convert the internalassert registered is selfto an explicitRuntimeError, matchingthe maintainer direction to remove bare asserts from the library
(they are behavioral no-ops under
-O).cuda_core/tests/memory_ipc/test_errors.py: addtest_register_rejects_mismatched_uuidcovering the rejection andverifying the resource's UUID is not rewritten on failure.
Checklist