feat(cuda.core): add cluster scheduling policy to LaunchConfig - #2702
Closed
atiaomar1978-hub wants to merge 6 commits into
Closed
feat(cuda.core): add cluster scheduling policy to LaunchConfig#2702atiaomar1978-hub wants to merge 6 commits into
atiaomar1978-hub wants to merge 6 commits into
Conversation
Expose CU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCE on LaunchConfig via ClusterSchedulingPolicyType, with validation, CC >= 9.0 gating, and tests mapping to the native launch attribute. Closes NVIDIA#2629 Co-authored-by: Cursor <cursoragent@cursor.com>
Assert LaunchConfig emits both CU_LAUNCH_ATTRIBUTE_CLUSTER_DIMENSION and CU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCE when set. Co-authored-by: Cursor <cursoragent@cursor.com>
Use init_cuda with an inline noop kernel so test_launcher.py does not depend on the get_saxpy_kernel_cubin fixture from test_module.py. Co-authored-by: Cursor <cursoragent@cursor.com>
…rough Align NVIDIA#2629 tests with reviewer guidance: round-trip each policy on LaunchConfig and exercise launch() for DEFAULT/SPREAD/LOAD_BALANCING. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
github-actions
Bot
added
the
cuda.core
3 tasks
Resolve _launch_config.pyi so LaunchConfig stubs keep the new cluster_scheduling_policy_preference field on current main. Co-authored-by: Cursor <cursoragent@cursor.com>
pre-commit.ci failed because the hand-merged .pyi did not match stubgen-pyx 0.2.19 output for cluster_scheduling_policy_preference. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
9 tasks
Contributor
Author
Contributor
Author
|
Closing in favor of signed PR #2703. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2629
Add
cluster_scheduling_policy_preferencetoLaunchConfig, mapping toCU_LAUNCH_ATTRIBUTE_CLUSTER_SCHEDULING_POLICY_PREFERENCEviaClusterSchedulingPolicyType(DEFAULT,SPREAD,LOAD_BALANCING).Unlike stream synchronization policy (#2628), cluster scheduling policy is
documented as valid for graph nodes and kernel launches, so
LaunchConfigisthe correct surface.
This replaces closed #2668 (GitHub would not reopen that PR). Tests now also
cover getter/setter round-trip and
launch()run-through for all threepolicies, per review guidance on #2629.
Checklist
Test plan
cluster+ policy attributeslaunch()smoke for all three policies (skip on CC < 9.0)Made with Cursor