Repository navigation
fix(quant): remove nn.Embeddings quantizers - #318
Merged
Merged
Conversation
Remove extra quantizers for `nn.Embeddings` not supported in modelopt v0.44.0. Signed-off-by: Mu-Ti Chung <mutic@nvidia.com>
pengcuo
approved these changes
Oct 27, 2026
lfengad
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove extra
nn.Embeddingsquantizers that are not supported in ModelOpt v0.44.0.Issue
Originally, edge was quantized with ModelOpt v0.47.0, while nano/super were quantized with v0.44.0. ModelOpt has
nn.Embeddingssupport in v0.47.0, which leads to restoration failure when loading the checkpoint with v0.44.0. We decided to revert the ModelOpt version to v0.44.0 to make all Cosmos3 FP8 checkpoints consistent.Example error message
Fix
Additional quantizer metadata for
nn.Embeddingsare removed. Those layers remain bfloat16 regardless of ModelOpt version, so removing the layer metadata resolves the issue.