Repository navigation
fix(eval): reuse the Framework checkout in the PAI-Bench-C launcher - #315
Open
salignatmoandal wants to merge 1 commit into
Open
salignatmoandal wants to merge 1 commit into
salignatmoandal wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PAI-Bench-C launcher exits before setup from its current
.agents/skills/evaluation/location because it only recognizes the legacycookbooks/cosmos3root. Even after recognizing Framework, its checkout selection would otherwise fall back to a nested clone underpackages/.Recognize the containing Framework checkout by
pyproject.tomlandcosmos_framework/, and reuse it before considering legacy nested checkouts. Preserve explicitCOSMOS3_REPOoverrides, clone destinations, and legacy cookbook layouts. Document checkout selection and the command for the new CPU path tests.Validation:
python3 -m unittest discover -s .agents/skills/evaluation/cosmos3/generator/paibench_c -p test_launcher_paths.py -vbash -n .agents/skills/evaluation/cosmos3/generator/paibench_c/run_paibench_c.shgit diff --check, passed.The tests exercise the actual bootstrap section before setup side effects; the invalid-root case executes the complete script. No model downloads, GPU inference, or benchmark scoring were performed. Shard counting and evaluation coverage remain outside this change.