Conversation
Signed-off-by: weimingc <17592131+meenchen@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
+ Coverage 71.41% 71.42% +0.01%
==========================================
Files 590 590
Lines 64692 64694 +2
==========================================
+ Hits 46197 46205 +8
+ Misses 18495 18489 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Reject non-finite AutoQuantize sensitivity scores before score normalization and solver construction. The error identifies the hyperparameter and candidate recipe instead of failing later inside PuLP. Checking before
min(score, prev_score)also prevents an infinite score from being hidden by a previous finite score.Draft: This improves diagnosis of the reported Qwen3.6 AutoQuantize failure. It does not yet fix the upstream numerical operation producing invalid scores; full-model reproduction and validation remain outstanding.
Usage
No API changes. Invalid scoring results now raise a descriptive
ValueError.Testing
Before your PR is "Ready for review"
CONTRIBUTING.md: N/A.Additional Information
Do not treat this draft as evidence that Qwen3.6 quantization succeeds. The remaining task is to locate the first invalid model output or gradient and validate the numerical fix end to end.