docs(catalog): record the setup-rust-toolchain v2 review outcome - #135
Merged
Merged
Conversation
v2.0.0 moves the implicit deny-warnings contract from RUSTFLAGS to the build.warnings cargo config (cargo >= 1.97); callers pinning older toolchains would silently lose the gate. Record the finding so the next refresh does not re-review from zero. Signed-off-by: rldyourmnd <danil@nddev.it.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the completed input-contract review of
setup-rust-toolchainv2.0.0 in the catalog notes:RUSTFLAGS=-D warningsbecomesbuild.warnings(defaultdeny) viaCARGO_BUILD_WARNINGS, requiring cargo >= 1.97 — silently weakening deny-warnings for callers pinning older toolchains. The bump stays held; Dependabot PR #129 remains the tracking surface.Test plan
Generated with Devin