Feat/smoke before release - #10
Merged
Merged
Conversation
upload-artifact does not preserve file modes, so the Linux AppImage loses the executable bit vpk set during the round trip through the publish artifact. Restore it in the release job before blob-upload zips it, or the downloaded AppImage would not run.
…e-test output_dir Note that smoke_timeout should stay at 180 or below since the smoke job has a fixed 6-minute timeout that also covers setup, explain how to recover when release holds back all platforms on one failure, mark output_dir as optional in the smoke-test example, and note that result.json is only written by apps on a smoke-aware Hermes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.