fix: lines-tab theme hint, folder reorder arrows, xTMode import - #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Three small user-reported gaps, one commit each:
cfg/orders.toml.xTMode(×10 scale) flag of the Trading block was never read, so imported S1–S6 came out ten times smaller than what Moonbot shows. The importer now reads the flag through the pinnedmoonproto::shared_configdecoder, switches the group to the extended TP mode with the main TP canonicalized the way the toolbar's ×10 checkbox does (0 → 100, so the exit generation survivescanonicalize()), imports S1–S6 as buffer value ×10, and shows the resulting mode/TP as its own preview row. Without the flag the import is unchanged.Plus a comment-only pass over the touched code.
How to verify
cargo fmt --all -- --checkclean;cargo test --workspacegreen (new unit tests: folder block move / nested / loose sibling / empty folder / boundary; xTMode on with default group → Extended + TP 100 + S×10, on with TP 250 → stays 250, off → plan identical to before).xTModeon was available on this machine.Fixes #538
Fixes #524
Fixes #527