Repository navigation
feat: Added search box to dynamic properties tab, added script search box support - #412
Open
AlexDenfordSkyboxLabs wants to merge 3 commits into
Open
AlexDenfordSkyboxLabs wants to merge 3 commits into
AlexDenfordSkyboxLabs wants to merge 3 commits into
Conversation
BrandonChanSkybox
approved these changes
Oct 23, 2026
BrandonChanSkybox
left a comment
BrandonChanSkybox
left a comment
Contributor
There was a problem hiding this comment.
Approved with questions for understanding
|
|
||
| eventHandlersByName.set(statisticDataProviderName, eventHandler); | ||
| }); | ||
| statisticDataProviders.registerWindowListener(window); |
Contributor
There was a problem hiding this comment.
Just leaving a question to make sure I understand correctly.
here you're using statisticDataProviders but in the previous version of the code it uses statsProvider which is an element in statisticDataProviders. Is statisticDataProviders no longer an array? Otherwise would we need to iterate through this still to run this method on all statsProviders still?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added search box to dynamic properties by default:
Added tech to script driven diagnostics so that they can opt into a search box as well