Repository navigation
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…ve-toolcalling-runtime
…ve-toolcalling-runtime
…ve-toolcalling-runtime
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native chat can now use the develop model service for real reasoning and native tools while retaining shared context maintenance. Normal content-only responses finish only on
stop; text accompanying tool calls remains intermediate. Unsupported or unknown tool capability falls back to CodeAgent per selected model, and missing reasoning capability does not request simulated ReAct reasoning.Depends on #4321 (shared non-blocking context maintenance), merged into this branch after its local built-container acceptance. Review/merge the shared PR first. Both PRs target develop; the separate v2.8.4 branch remains standalone.
The integration records provider input usage against the actual request/profile, preserves native call/result order during result compaction, binds owned original outputs to persisted references, exposes direct/programmatic readers, and performs bounded rebuild only for explicit provider input overflow without replaying completed effects. Estimates and failed maintenance do not independently reject chat or an Agent run. Output
lengthremains an incomplete generation, not generic input overflow.Validation:
stoprequired an explicit follow-up; completed effects were not replayed. A direct-only harness assertion was corrected after verifying actual programmatic MCP execution.Limits/findings: conservative fact guards can reject summaries and add latency while preserving original history. Supplementary reruns also recorded a fallback model returning unexecuted Python in its final answer (one bounded fresh D2 rerun passed) and a too-small offload fixture: no reference was issued below threshold, the model guessed references and repeated producers until max steps. That failed chat/trace is retained; a fresh pressure-triggered fixture passed with one producer and one real read. These failures are not counted as passes. The long run encountered an external embedding timeout and an auxiliary memory-extraction LLM failure; chat still completed. Full long prompts exceed the existing 100k-character Phoenix input-preview bound; complete final output, persisted history, context fingerprints and budget provenance were verified separately. This is representative feature coverage, not exhaustive certification of every UI, multimodal/provider, long-term memory or dreaming path. Existing authoring services intentionally retain CodeAgent through the new model service. Full-Case semantic-review status remains distinct from mapped formal execution.
Test chats, Agent/model/KB/MCP/Skill/memory resources and Phoenix traces are retained for review at the user's request. Agent 6 v2; long-run conversation 14; model 32; embedding 33; fallback model 34; MCP 1; Skill 7. Current evidence and limitations are maintained in the workspace SPEC execution record.
Final CI on 5dd1ae2: all 16 checks passed; 23,933 unit tests passed, 32 skipped, zero failed; Codecov patch 93.01471%. Both image architectures, type checking, copyright and CodeQL are green. Final host main image 1d8637b4...; 16 native test conversations and all persistent fixture resources/traces retained.
Reasoning visibility recheck: the retained long-run campaign used test outlet 32 with enable_thinking=false. Enabled only that owned setting (saved revision 3), preserving output/context budgets and Agent definitions. Ordinary chats 20–23 now retain real Qwen/GLM reasoning, including MCP/Python calls; stream and saved reasoning hashes match, and both providers render Reasoning cards after reload/reopen. Source/image remain 5dd1ae2/1d8637b4..., with no additional product code change. All original chats/resources and default Phoenix traces remain retained.
Native stream compatibility follow-up: ordinary model text streams as
model_output_thinking, provider reasoning streams asmodel_output_deep_thinking, and a successful text-only stop emits the full accepted body infinal_answer. Removed the experimentalmodel_outputchat path. A one-time PostgreSQL update on the test host converted 18 saved message units across seven chats, verified their other fields and left zero rows with the experimental type. History API, browser, installed HTTP/SSE scenarios and Qwen on Phoenix default confirm the deployed behavior. All 16 checks pass on f68a742 with 23,933 tests passed, 32 skipped and 93.00613% patch coverage.