fix: require stops.txt before GTFS batch publish - #1828
Open
mackenziereading19 wants to merge 1 commit into
Open
fix: require stops.txt before GTFS batch publish#1828mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the GTFS batch scheduler only publishes feeds whose latest dataset contains
stops.txt, while preserving first-time ingestion for feeds that do not yet have a latest dataset.The resulting behavior is:
stops.txtremain eligible;stops.txtare skipped.This uses the persisted GTFS file inventory introduced by #1259 and keeps the check at the scheduler boundary before publishing the Pub/Sub message.
Tests
functions-python/batch_datasets/testssuite: 5 passed;functions-python/.flake8: pass.Fixes #1271