Skip to content

fix: require stops.txt before GTFS batch publish - #1828

Open
mackenziereading19 wants to merge 1 commit into
MobilityData:mainfrom
mackenziereading19:1271-require-stops-before-batch-publish
Open

fix: require stops.txt before GTFS batch publish#1828
mackenziereading19 wants to merge 1 commit into
MobilityData:mainfrom
mackenziereading19:1271-require-stops-before-batch-publish

Conversation

@mackenziereading19

Copy link
Copy Markdown
Contributor

Summary

Ensure the GTFS batch scheduler only publishes feeds whose latest dataset contains stops.txt, while preserving first-time ingestion for feeds that do not yet have a latest dataset.

The resulting behavior is:

  • feeds with no latest dataset remain eligible for publication;
  • feeds whose latest dataset contains stops.txt remain eligible;
  • feeds whose latest dataset exists but does not contain stops.txt are skipped.

This uses the persisted GTFS file inventory introduced by #1259 and keeps the check at the scheduler boundary before publishing the Pub/Sub message.

Tests

  • focused regression covering the three cases above;
  • full functions-python/batch_datasets/tests suite: 5 passed;
  • Black: pass;
  • Flake8 with functions-python/.flake8: pass.

Fixes #1271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check existence of stops.txt after #1259 is merged

1 participant