Repository navigation
Test every aggregate of the typed surface against MobilityDB's answer - #85
Merged
estebanzimanyi merged 1 commit intoOct 19, 2026
Conversation
AggregatesCatalogTest runs each of the 263 aggregate overloads the typed Spark SQL surface registers over two rows of sample values, repartitioned so that the partial states merge, and compares the text of its answer with the one MobilityDB gives over the same rows in the time zone UTC, which the test states. A value whose text carries a coordinate or a float is written with six decimals, as MobilityDuck's test/sql/aggregates_catalog.test writes it over the same rows. The test also states the 22 aggregate names the surface registers, the catalog's but for the three raster aggregates, which the codegen of JMEOS leaves out, and checks that those three are not registered. The point cloud values name pcid 1, three dimensions of type double, which src/test/resources/pointcloud_schemas.xml states and the test hands to MEOS before the SparkSession is built.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AggregatesCatalogTest runs each of the 263 aggregate overloads the typed Spark SQL surface
registers over two rows of sample values, repartitioned so that the partial states merge, and
compares the text of its answer with the one MobilityDB gives over the same rows in the time zone
UTC, which the test states. A value whose text carries a coordinate or a float is written with six
decimals, as MobilityDuck's test/sql/aggregates_catalog.test writes it over the same rows.
The test also states the 22 aggregate names the surface registers, the catalog's but for the three
raster aggregates, which the codegen of JMEOS leaves out, and checks that those three are not
registered.
The point cloud values name pcid 1, three dimensions of type double, which
src/test/resources/pointcloud_schemas.xml states and the test hands to MEOS before the SparkSession
is built.