Repository navigation
Call the window average wAvgAgg - #84
Merged
estebanzimanyi merged 1 commit intoOct 18, 2026
Merged
Conversation
The test of the window aggregates calls the window average wAvgAgg, the name the MEOS catalog states for Tnumber_wavg_transfn (`@altsqlfn wAvgAgg()` on MobilityDB master) and the name JMEOS's codegen_jvm.py registers it under, an aggregate taking its catalog altSqlName. Why: the build derives the surface from the catalog of MobilityDB master, which names the aggregate wAvgAgg in the engines, MobilityDB keeping wAvg; DuckDB names its weighted average wavg and compares names without case, so the three engines take the one name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test of the window aggregates calls the window average wAvgAgg, the name the MEOS catalog
states for Tnumber_wavg_transfn (
@altsqlfn wAvgAgg()on MobilityDB master) and the name JMEOS'scodegen_jvm.py registers it under, an aggregate taking its catalog altSqlName.
Why: the build derives the surface from the catalog of MobilityDB master, which names the
aggregate wAvgAgg in the engines, MobilityDB keeping wAvg; DuckDB names its weighted average wavg
and compares names without case, so the three engines take the one name.