Repository navigation
Build the span set of the array test from increasing spans - #83
Merged
estebanzimanyi merged 1 commit intoOct 17, 2026
Merged
Conversation
The test reading an array of fixed-size values as the contiguous C array MEOS takes builds its
span set from `[1, 3)` and `[5, 7)` in that order, and answers `{[1, 3), [5, 7)}`. A span set
holds its spans increasing, and the public constructor refuses them in any other order, as the
SQL constructor does.
Witness: with MobilityDB master `87c5269563` (whose #3073 makes the public constructors answer what
the SQL constructors answer) the test, building the set from `[5, 7)` then `[1, 3)`, fails
`GeneratedSqlSurfaceTest.arraysCrossAsSparkArrays` with "The spans composing a span set must be
increasing: [5, 7), [1, 3)".
Measured: the JMEOS receipt building and testing MobilitySpark at this branch over MobilityDB
`87c5269563` and MEOS-API `068f4bf353` runs the suite with no failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test reading an array of fixed-size values as the contiguous C array MEOS takes builds its
span set from
[1, 3)and[5, 7)in that order, and answers{[1, 3), [5, 7)}. A span setholds its spans increasing, and the public constructor refuses them in any other order, as the
SQL constructor does.
Witness: with MobilityDB master
87c5269563(whose #3073 makes the public constructors answer whatthe SQL constructors answer) the test, building the set from
[5, 7)then[1, 3), failsGeneratedSqlSurfaceTest.arraysCrossAsSparkArrayswith "The spans composing a span set must beincreasing: [5, 7), [1, 3)".
Measured: the JMEOS receipt building and testing MobilitySpark at this branch over MobilityDB
87c5269563and MEOS-API068f4bf353runs the suite with no failure.