Repository navigation
Check the append aggregates on the typed Spark surface - #80
Merged
estebanzimanyi merged 1 commit intoOct 11, 2026
Merged
Conversation
GeneratedSqlSurfaceTest.appendAggregatesAnswerWhatMobilityDBAnswersOrderedByTime checks that appendInstantAgg over temporal integers, over temporal floats with the interpolation discrete, and with the interpolation linear, a distance of 1.5 and an interval of one day, over temporal booleans with the interpolation step and an interval of one day, and appendSequenceAgg over temporal integer sequences answer what MobilityDB answers over the same values ordered by their start timestamp, the values given out of that order, each in a partition of its own, so the aggregate orders them whatever order it receives; and that two values at one timestamp are refused with MobilityDB's error, "The temporal values have different value at their common timestamp". Witness: with the generator of JMEOS ba1e61c3, before #172, the surface registers neither aggregate, the 77 overloads of appendInstantAgg and appendSequenceAgg left out as stating no combine. Measured over MobilityDB 3a8e6dba09, the catalog of MEOS-API 4baf11705c and JMEOS main e8c65dc4: the 45 tests pass, 17 of them in GeneratedSqlSurfaceTest, with 0 warnings. Why: a trajectory built from its instants or its pieces answers on Spark as it does in PostgreSQL, whatever order Spark hands the rows in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GeneratedSqlSurfaceTest.appendAggregatesAnswerWhatMobilityDBAnswersOrderedByTime checks that
appendInstantAgg over temporal integers, over temporal floats with the interpolation discrete,
and with the interpolation linear, a distance of 1.5 and an interval of one day, over temporal
booleans with the interpolation step and an interval of one day, and appendSequenceAgg over
temporal integer sequences answer what MobilityDB answers over the same values ordered by their
start timestamp, the values given out of that order, each in a partition of its own, so the
aggregate orders them whatever order it receives; and that two values at one timestamp are
refused with MobilityDB's error, "The temporal values have different value at their common
timestamp".
Witness: with the generator of JMEOS ba1e61c3, before #172, the surface registers neither aggregate, the
77 overloads of appendInstantAgg and appendSequenceAgg left out as stating no combine.
Measured over MobilityDB 3a8e6dba09, the catalog of MEOS-API 4baf11705c and JMEOS main e8c65dc4:
the 45 tests pass, 17 of them in GeneratedSqlSurfaceTest, with 0 warnings.
Why: a trajectory built from its instants or its pieces answers on Spark as it does in
PostgreSQL, whatever order Spark hands the rows in.