Repository navigation
Evaluate the aggregate overloads over the same rows in one query - #91
Merged
estebanzimanyi merged 1 commit intoOct 25, 2026
Merged
estebanzimanyi merged 1 commit into
estebanzimanyi merged 1 commit into
Conversation
theOverloadAnswersWhatMobilityDBAnswers evaluates the cases of OVERLOADS that aggregate the same rows as the columns of one query, each case still a test of its own reading its answer. A query that fails is run again case by case through answer, so a failing case raises its own error. Witness: each case was a query of its own, a job the mini-cluster plans and submits, so the class spent its time on jobs rather than on aggregates; it was the largest class left in the binding's test step after TopologicalPositionSurfaceTest shared its jobs. Measured: the 268 cases aggregate 75 distinct sources of rows, so 268 jobs become 75 at most. On the same machine and stack, AggregatesCatalogTest passes its 296 tests in 106.0 s, against 253.0 s with a job per case; on the CI of main the class took 179.1 s of the step. Why: a query per aggregate measures Flink's job submission, not the surface; sharing the jobs keeps every case and every check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theOverloadAnswersWhatMobilityDBAnswers evaluates the cases of OVERLOADS that aggregate the same
rows as the columns of one query, each case still a test of its own reading its answer. A query
that fails is run again case by case through answer, so a failing case raises its own error.
Witness: each case was a query of its own, a job the mini-cluster plans and submits, so the class
spent its time on jobs rather than on aggregates; it was the largest class left in the binding's
test step after TopologicalPositionSurfaceTest shared its jobs.
Measured: the 268 cases aggregate 75 distinct sources of rows, so 268 jobs become 75 at most. On
the same machine and stack, AggregatesCatalogTest passes its 296 tests in 106.0 s, against 253.0 s
with a job per case; on the CI of main the class took 179.1 s of the step.
Why: a query per aggregate measures Flink's job submission, not the surface; sharing the jobs
keeps every case and every check.