Repository navigation
Evaluate the topological and position overloads a hundred to a query - #89
Merged
estebanzimanyi merged 1 commit intoOct 25, 2026
Conversation
everyOverloadAnswersUnquoted evaluates the two-argument overloads of the topological and position families a hundred to a query: the calls are the columns of one query, each column required to answer a Boolean, and a query that fails is run again call by call through #scalar, so a failing overload is named by its own query and the innermost cause. Witness: each overload was a query of its own, and each query is a job the mini-cluster plans and submits, so the test spent its time on jobs rather than on calls. Measured: on the CI of main the step building and testing the binding takes 1274 s, against 154 s for MobilitySpark's, and TopologicalPositionSurfaceTest takes 1022 s of it for its three tests. A query costs 0.53 s on Flink and 0.08 s on Spark, read from AggregatesCatalogTest (288 queries in 152.7 s, 295 in 23.4 s). On the CI of this change (fork run 40190727763) the three tests of TopologicalPositionSurfaceTest pass in 116.7 s. Why: a query per call measures Flink's job submission, not the surface; sharing the jobs keeps every call and every check while the test costs a tenth of its time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
everyOverloadAnswersUnquoted evaluates the two-argument overloads of the topological and position
families a hundred to a query: the calls are the columns of one query, each column required to
answer a Boolean, and a query that fails is run again call by call through #scalar, so a failing
overload is named by its own query and the innermost cause.
Witness: each overload was a query of its own, and each query is a job the mini-cluster plans and
submits, so the test spent its time on jobs rather than on calls.
Measured: on the CI of main the step building and testing the binding takes 1274 s, against 154 s
for MobilitySpark's, and TopologicalPositionSurfaceTest takes 1022 s of it for its three tests. A
query costs 0.53 s on Flink and 0.08 s on Spark, read from AggregatesCatalogTest (288 queries in
152.7 s, 295 in 23.4 s). On the CI of this change (fork run 40190727763) the three tests of
TopologicalPositionSurfaceTest pass in 116.7 s.
Why: a query per call measures Flink's job submission, not the surface; sharing the jobs keeps
every call and every check while the test costs a tenth of its time.