Repository navigation
Register a commuted container signature under the name it declares - #499
Merged
estebanzimanyi merged 1 commit intoOct 24, 2026
Conversation
A function over two containers that the catalog states under two SQL names, one per argument order, registers each signature under its own name. distance_intspanset_intspan answers spansetDistance(intspanset, intspan) and, its operands swapped, spanDistance(intspan, intspanset); container_scalar_sigs returns the name each signature declares beside its argument types and its order, and the registration reads it instead of the function's first name. Measured: on main, the swapped forms register as spansetDistance(intspan, intspanset) and its siblings over bigint, float, date and tstz, a name MobilityDB does not declare, and spanDistance(span, spanset) registers nothing. Over the catalog of MobilityDB ac8feb51dc, the commit this branch's pin records, the five register as spanDistance and the five spansetDistance forms with the span first leave; no other registration changes and none is registered twice. test/sql/container_distance.test reads spanDistance(span, spanset) against spansetDistance with the operands swapped, and refuses spansetDistance with the span first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A function over two containers that the catalog states under two SQL names, one per argument order, registers each signature under its own name. distance_intspanset_intspan answers spansetDistance(intspanset, intspan) and, its operands swapped, spanDistance(intspan, intspanset); container_scalar_sigs returns the name each signature declares beside its argument types and its order, and the registration reads it instead of the function's first name.
Measured: on main, the swapped forms register as spansetDistance(intspan, intspanset) and its siblings over bigint, float, date and tstz, a name MobilityDB does not declare, and spanDistance(span, spanset) registers nothing. Over the catalog of MobilityDB ac8feb51dc, the commit this branch's pin records, the five register as spanDistance and the five spansetDistance forms with the span first leave; no other registration changes and none is registered twice. test/sql/container_distance.test reads spanDistance(span, spanset) against spansetDistance with the operands swapped, and refuses spansetDistance with the span first.