Repository navigation
Advance the MEOS commit and regenerate the UDF surface - #493
Merged
Merged
Conversation
pcid(tpcpatch), pcid(tpcpoint) and numPoints(tpcpatch) are registered by the generator from tpcpatch_pcid, tpcpoint_pcid and tpcpatch_npoints of meos_pointcloud_accessor, a group in RETIRED_GROUPS, with the unsigned types MEOS returns. spanIntersection and * of a value and a span, value first, are registered from intersection_int_span and its siblings of meos_setspan_set. The hand registrations of the same signatures, their helpers Tpcpatch_pcid, Tpcpatch_numpoints, Tpcpoint_pcid and SpanFunctions::Intersection_value_span, SpanTypes::RegisterScalarFunctions and the declarations of the pointcloud functions only they called go. Witness: with both registrations, pcid(tpcpatch) and pcid(tpcpoint) fail to bind, "Could not choose a best candidate function", the candidates returning UINTEGER and INTEGER (test/sql/tpcpatch.test:109, test/sql/tpcpoint.test:115). Measured: the suite passes, 4884 assertions in 121 test cases, built with g++-14 against the MEOS port of this pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The committed
src/generated/drifted from a fresh derivation againstMobilityDB/MobilityDB master; this regenerates it and moves
_MEOS_REFinvcpkg_ports/meos/portfile.cmaketo the commit it isderived from, so libmeos and the surface stay one commit.
Opened by the
Refresh generated surface from MobilityDB masterworkflow.