Repository navigation
Record the sort keys of a span and a span set in the Spark gaps ledger - #190
Merged
estebanzimanyi merged 1 commit intoOct 25, 2026
Merged
Conversation
MobilityDB makes public the order-preserving sort keys of a span and a span set, span_sortkey and spanset_sortkey, each returning a byte array through a pointer and its length, which the Spark UDF surface does not carry, as for setstate_serialize, which the ledger lists with that return. tools/spark-udf-gaps.txt lists the 2. Witness: over MobilityDB master bc6f2729ea and MEOS-API master 71c23da the step refusing a public function the Spark surface stops reaching fails on main's ledger with "2 public functions the surface does not reach and the ledger does not list", naming span_sortkey and spanset_sortkey, each array-or-out-param:size and unsupported-return:uint8_t *. Measured over the same pair with the jar built from that catalog and that libmeos: the step reports no function missing from the ledger, which lists 778 functions; the build runs 127 codegen and 1804 jmeos-core tests with no failure, skip or warning line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MobilityDB makes public the order-preserving sort keys of a span and a span set, span_sortkey and spanset_sortkey, each returning a byte array through a pointer and its length, which the Spark UDF surface does not carry, as for setstate_serialize, which the ledger lists with that return. tools/spark-udf-gaps.txt lists the 2.
Witness: over MobilityDB master bc6f2729ea and MEOS-API master 71c23da the step refusing a public function the Spark surface stops reaching fails on main's ledger with "2 public functions the surface does not reach and the ledger does not list", naming span_sortkey and spanset_sortkey, each array-or-out-param:size and unsupported-return:uint8_t *.
Measured over the same pair with the jar built from that catalog and that libmeos: the step reports no function missing from the ledger, which lists 778 functions; the build runs 127 codegen and 1804 jmeos-core tests with no failure, skip or warning line.