Skip to content

chore: Hide HF unauthenticated warning - #270

Merged
Pringled merged 3 commits into
mainfrom
fix/hide-hf-unauthenticated-warning
Sep 18, 2026
Merged

Pringled merged 3 commits into
mainfrom
fix/hide-hf-unauthenticated-warning

Conversation

@Pringled

Copy link
Copy Markdown
Member

We currently show the following warning on the first use of semble because we download potion code from HF hub:

"Warning: You are sending unauthenticated requests to the HF Hub. "
            "Please set a HF_TOKEN to enable higher rate limits and faster downloads.",

This PR hides that since the model downloads fine without it and it only adds confusion. The useful errors if anything actually goes wrong are still shown.

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/semble/index/dense.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Sep 18, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The PR appears safe to merge, though narrowing the filter would prevent unrelated token diagnostics from being suppressed.

Reviews (1) · Last reviewed commit: "test: Use exact Hub warning text in HF_T..."

Comment thread src/semble/index/dense.py Outdated

@stephantul stephantul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the greptile comment (I think you could make the filter even more specific?) this is fine.

@Pringled
Pringled merged commit 8e40653 into main Sep 18, 2026
16 checks passed
@Pringled
Pringled deleted the fix/hide-hf-unauthenticated-warning branch September 18, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants