Repository navigation
Conversation
darkseid 9.1.0 adds MetronInfo v1.2 schema support. A file using the new v1.2 Series elements (EndYear, Status, Summary) now validates as METRON_INFO_V1_2, which --validate reported as "not valid" and could then delete. Add a v1.2 entry to the validation messages.
bpepple
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
darkseidto>=9.1.0, which adds MetronInfo v1.2 schema support.SchemaVersion.METRON_INFO_V1_2to the--validatemessages inrun.py.Why
darkseid 9.1.0 checks MetronInfo against v1.1 first, then v1.2. A file that uses any of the new v1.2 Series elements (
EndYear,Status,Summary) fails v1.1 and comes back asMETRON_INFO_V1_2. Without this change,--validatereports those files as "not valid" and, with the remove-metadata option, deletes their valid MetronInfo.No other changes are needed:
METRON_INFO_V1_1is unchanged, and the newSeriesfields (end_year,status,summary) aren't populated because mokkari's issue response doesn't include them.