chore!: Drop Node 18 and 20 - #9976
Open
Mrtenz wants to merge 3 commits into
Open
Conversation
Mrtenz
changed the title
mcmire
reviewed
Aug 26, 2026
Mrtenz
force-pushed
the
mrtenz/drop-node-20
branch
2 times, most recently
from
August 26, 2026 18:49
00f0bc1 to
beac0dd
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
force-pushed
the
mrtenz/drop-node-20
branch
from
August 27, 2026 08:50
beac0dd to
8dabedc
Compare
Mrtenz
marked this pull request as ready for review
August 27, 2026 11:54
mcmire
reviewed
Aug 27, 2026
|
|
||
| ### Changed | ||
|
|
||
| - **BREAKING:** Bump minimum Node.js version to 22 ([#9168](https://github.com/MetaMask/core/pull/9168)) |
Collaborator
There was a problem hiding this comment.
Are these PR numbers outdated? I believe that's why the changelog check action is failing:
Suggested change
| - **BREAKING:** Bump minimum Node.js version to 22 ([#9168](https://github.com/MetaMask/core/pull/9168)) | |
| - **BREAKING:** Bump minimum Node.js version to 22 ([#9976](https://github.com/MetaMask/core/pull/9976)) |
(and so on, for the other packages)
Mrtenz
force-pushed
the
mrtenz/drop-node-20
branch
from
August 27, 2026 21:31
8dabedc to
0eaec02
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0eaec02. Configure here.
Mrtenz
force-pushed
the
mrtenz/drop-node-20
branch
2 times, most recently
from
August 28, 2026 11:07
a496078 to
6312a0f
Compare
Node 18 and 20 are EOL, we should not support them anymore. This PR makes a breaking change to every single package in the monorepo. This also reduces the number of jobs we need to run in CI. <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **High Risk** > Semver-breaking platform change across all packages: consumers on Node 18/20 must upgrade before adopting new releases. CI no longer catches regressions on those versions. > > **Overview** > **BREAKING:** The monorepo now requires **Node.js `^22.14.0 || ^24`** everywhere. Root and every workspace `package.json` `engines.node` moves off `^18.18 || >=20`, and `yarn.config.cjs` enforces the same range (including `@metamask/wallet-cli`, which previously allowed `>=20`). > > CI in `lint-build-test.yml` stops testing on **18.x** and **20.x**: the prepare matrix and per-package test jobs run only **22.x** and **24.x**, with `test-18` / `test-20` removed and `test-24` added. Each package’s **Unreleased** changelog records the Node bump. > > Because Node 22 exposes **Web Crypto** globally, custom Jest setups that assigned `crypto.webcrypto` are removed (`keyring-controller`, `passkey-controller`, `seedless-onboarding-controller`, `money-account-upgrade-controller`, and partial cleanup in `notification-services-controller` / `profile-sync-controller`). Related `jest-environment-node` devDependencies and `Wallet` / encryptor test `beforeAll` polyfills go away. `platform-api-docs` drops the comment justifying `fs.cp` on older Node versions. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 50b2f4c. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Mrtenz
force-pushed
the
mrtenz/drop-node-20
branch
from
August 28, 2026 11:09
6312a0f to
12ce9cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 18 and 20 are EOL, we should not support them anymore. This PR makes a breaking change to every single package in the monorepo. This also reduces the number of jobs we need to run in CI.
This change was originally merged into the
esmfeature branch, but using a stacked pull request seems cleaner here.Note
Medium Risk
Semver-breaking for all published packages: consumers on Node 18/20 must upgrade. Runtime code changes are mostly test/CI and polyfill removal, but the blast radius across the monorepo is large.
Overview
BREAKING: The monorepo now requires Node.js
^22.14.0or^24everywhere—root and every workspaceengines.node, enforced inyarn.config.cjs(including@metamask/wallet-cli, which previously allowed>=20).CI in
lint-build-test.ymldrops 18.x and 20.x: prepare and per-package tests run only on 22.x and 24.x (the oldtest-18/test-20matrix jobs are removed). Wallet-cli daemon e2e likewise drops Node 20 from its matrix.Dev tooling aligns with Node 22: root and several packages bump
@types/nodefrom 16.x to^22.13.14, with lockfile updates.Test harness cleanup assumes Node’s built-in Web Crypto: custom Jest environments and
beforeAllwebcryptoshims are removed from packages such askeyring-controller,passkey-controller,seedless-onboarding-controller, andmoney-account-upgrade-controller; partialcryptopolyfills are trimmed where a custom env remains.platform-api-docsdrops the oldfs.cpNode-range eslint workaround.Each affected package records the change under Unreleased (or the relevant release section) as a BREAKING minimum Node bump (#9168).
Reviewed by Cursor Bugbot for commit 12ce9cf. Bugbot is set up for automated code reviews on this repo. Configure here.