Repository navigation
Conversation
|
@DeFex-lab is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@DeFex-lab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
DeFex-lab
force-pushed
the
fix/issue-606-controller-specs-pass-unbound-methods-to-expect
branch
from
October 22, 2026 09:54
70c8df4 to
51258d6
Compare
4 tasks
chonilius
added a commit
that referenced
this pull request
Oct 29, 2026
…alidation fix: wallet disconnect fails silently — add DELETE /users/:id/stellar-address (#714)
Proxima84-code
pushed a commit
to Proxima84-code/backend
that referenced
this pull request
Oct 31, 2026
…ergeFi#714) PATCH { stellarAddress: null } always returned 400 because the @IsStellarAddress() validator on SetStellarAddressDto only accepts a valid Stellar Ed25519 public key — null never passes StrKey validation. The disconnect() call on the frontend was silently swallowed by its .catch(() => {}) so the failure was invisible to users and maintainers. Adds a dedicated DELETE :id/stellar-address route that accepts no body and sets user.stellarAddress to null via a new clearStellarAddress() service method, keeping the PATCH route strictly typed for real addresses.
Proxima84-code
pushed a commit
to Proxima84-code/backend
that referenced
this pull request
Oct 31, 2026
MergeFi#714) Adds two spec blocks: - users.service.spec.ts: NotFoundException on missing user; null written to stellarAddress and persisted via userRepo.save. - users.controller.spec.ts: wires the clearStellarAddress mock; asserts the happy path returns stellarAddress: null and the cross-user attempt throws ForbiddenException without calling the service.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
@typescript-eslint/unbound-methodlint errors in the GitHub controller specs, where unbound method references were passed toexpect(). The offending assertions are replaced withjest.spyOn-based references sonpm run lintcan pass while keeping the rule enabled.Related Issue
Changes
🧪 Controller Spec Fixes
[MODIFY]
src/github/github.controller.spec.tsexpect(controller.sync)-style references at lines 62 and 71 withjest.spyOn-based assertions, so the method is referenced through a bound spy rather than an unbound prototype method.[MODIFY]
src/github/github-webhooks.controller.spec.tsjest.spyOn-based assertion, consistent with the fix in the other spec.Verification Results
unbound-methoderrors atgithub.controller.spec.ts:62and:71are resolvedjest.spyOnunbound-methoderror atgithub-webhooks.controller.spec.ts:142is resolvedjest.spyOn@typescript-eslint/unbound-methodrule is kept enabledCloses #606