fix(exec.sh): restore names only the errors the script added - #179
Merged
Merged
Conversation
On a model that already had errors, the restore listed every error with the new one unmarked, then said the errors were pre-existing, that the script was not the cause, and that nothing would exec until they were cleared. Both false. Now the headline counts the new errors, the report lists them first in full and summarises the old ones, and the attribution and build log say the script was rolled back for its own errors. New/old uses the gate's own error key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
MendixMau
marked this pull request as ready for review
September 30, 2026 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why (one paragraph)
Follow-up to #178. When
exec.shundid a script on a model that already had errors, it printed every error on the model with the new one unmarked, then said the errors were "PRE-EXISTING … This script is NOT the cause. Nothing will exec until that is cleared" and logged "blocked". Both statements were false: the script had added the error, and the delta gate keeps any later script that adds nothing new. Now the headline says how many errors this script added (and how many were already there), the new errors are listed in full, the old ones are summarised one line per code, and the attribution and build log say the script was rolled back for its own errors. The new/old split uses the gate's own error key (ERRKEY_PY, shared byerr_setand the newerr_report), so the verdict and the report cannot disagree. With no measured baseline (SKIP_BASELINE=1) the output is unchanged.Field evidence
Scratch copy of a greenfield PoC project (Mendix 11.x) with 22 known errors (CE0462 x20, CE0117, CE0100). Real
.mpruntouched.err_setoutput checked identical to #178's on the real error capture.Checklist
tests/wave2/test-bug07-08.shusesSKIP_BASELINE=1, whose path is unchanged🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Generated by Claude Code