[MemerGamer]

[MemerGamer]

Review: LGTM, no changes pushed.

• FTP sync TryGetValue/indexer: no production caller remains outside FtpManager.cs. Connection-time lookups go through FtpClientFactory.CreateAsync -> TryGetSavedAsync (session, then saved, then URL, same order as before), so there is no re-prompt regression. Only tests use the sync TryGetValue. Get and the indexer are now dead code; optional cleanup.
• Secret path: no .Result/.Wait()/GetResult() on it. The per-key SemaphoreSlim is released in finally, and the store uses ConfigureAwait(false) throughout. The in-memory fallback and tombstone logic are unchanged. The slow-unlock tests call the store synchronously and then wait for the prompt, so they would hang if the call blocked.
• Windows paths (CredentialsHelpers PasswordVault branches, DevToolsViewModel) are logically fine. Notes, not blockers: DoRemoveCredentialsAsync is async void behind a RelayCommand, matching the existing DoConnectToGitHubAsync. The logout-enabled flag is now set after construction and is an observable property.
• Line endings: the repo stores these files as LF (text=auto; main is LF too), so there is no CRLF problem. No scope creep.
• Local: Files.Platform.Tests builds with -warnaserror and passes (1464 passed, 11 skipped, 0 failed). I did not rebuild Files.App locally; the CI run was still pending.

🤖 Generated with Claude Code