Repository navigation
Feature: Prompt to unlock the keyring before falling back to memory storage - #205
Merged
Merged
Conversation
When the Secret Service collection or item is locked, call Service.Unlock and, if a prompt is returned, show it via Prompt.Prompt and await Completed. The original operation is then retried once. A dismissed, failed or timed-out unlock falls back to the in-memory store, with a cooldown so a refusing user is not re-prompted on every save. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Summary
SecretServiceStorenow callsorg.freedesktop.Secret.Service.Unlockfor a locked collection or item. If the service needs a prompt, it shows the desktop keyring prompt and retries.Steps used to test these changes
tests/Files.Platform.Testsin Release with-warnaserrorand ran it underxvfb-run: 1459 passed, 0 failed, 0 skipped.src/Files.Appfornet10.0-desktopin Release: succeeded.-p:FilesWin32Compat=false: succeeded.🤖 Generated with Claude Code