fix: Send only the suggester options to the project manager search - EXO-90713 - #657
Merged
boubaker merged 1 commit intoOct 5, 2026
Merged
Conversation
boubaker
changed the title
boubaker
marked this pull request as ready for review
September 28, 2026 16:32
ahamdi
previously approved these changes
Sep 29, 2026
exo-swf
dismissed
ahamdi’s stale review
September 30, 2026 23:18
The merge-base changed after approval.
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
October 1, 2026 23:18
5f3a58d to
2a5a860
Compare
…EXO-TBD ProjectAssigneeManager passed the whole current user object as the suggester's currentUser option, and outside a space it returned that object as the options themselves, so every profile field went into the people suggest query string. A long profile made the request fail. The manager field now sends the same options as the participants field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boubaker
force-pushed
the
fix/project-manager-suggester-options
branch
from
October 5, 2026 12:48
c2cf7f7 to
a041696
Compare
Member
Author
|
Rebased on top of new feature/maintenance |
boubaker
enabled auto-merge (squash)
October 5, 2026 12:50
|
Jihed525
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom: in a project's settings, the manager suggester fails for a user with a long profile (for example a long work-experience text): the people suggest request URL grows with every profile field (Meeds-io/meeds#4023).
Cause:
ProjectAssigneeManager.vuepassed the whole current user object as the suggester'scurrentUseroption inside a space, and returned that object as the options themselves outside a space.SuggesterService#searchUsersmerges the options into the query string with$.param.Fix: the manager field sends the options the participants field already sends (
ProjectAssigneeParticipator.vue):{ spaceURL, currentUser: false }in a space,{}otherwise, where the suggester's defaultcurrentUser(the user name) applies. Checked by the build and lint; the frontend has no committed JS unit tests.Knowledge: none — the fix aligns a component on its sibling; no platform fact changes.
This change is classified N1 (computed on
c2cf7f779, raised for identity resolution: the suggest endpoint uses thecurrentUserparameter as the viewer identity) — its approver must be an Archi/Dev who knows it is N1, not an approval on AI review alone; author ≠ approver.🤖 Generated with Claude Code