Repository navigation
fix: Authorize task creation on the project of the resolved status - EXO-90711 - #656
Merged
boubaker merged 1 commit intoOct 5, 2026
Merged
Conversation
boubaker
changed the title
boubaker
marked this pull request as ready for review
September 28, 2026 16:31
ahamdi
previously approved these changes
Sep 29, 2026
exo-swf
dismissed
ahamdi’s stale review
September 30, 2026 23:18
The merge-base changed after approval.
exo-swf
force-pushed
the
feature/maintenance
branch
2 times, most recently
from
October 1, 2026 23:18
5f3a58d to
2a5a860
Compare
…EXO-TBD When a status id is posted, addTask loads the status and checks the view permission on its own project; an unknown status is a bad request. A creation always starts from id 0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boubaker
force-pushed
the
fix/add-task-authorize-status-project
branch
from
October 5, 2026 13:02
2c33c40 to
10a10ea
Compare
Member
Author
|
Rebased on new feature/maintenance |
|
Jihed525
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
TaskRestService#addTaskauthorizes on the project the task is actually stored in. When a status id is posted, the status is loaded throughStatusServiceand the view permission is checked on its own project; an unknown status is a 400. A creation always starts from id 0. Creation with a project and no status id (default status) is unchanged.Tests:
TestTaskRestService#testAddTaskAuthorizesOnTheProjectOfThePostedStatusfails on the previous code; each guard, reverted, fails it.Knowledge: to follow — the eng-standards pitfall ledger PR that records this surface, opened after its dedup with the parallel backfill; its entry is re-stamped once this fix reaches develop.
This change is classified N1 (computed on
2c33c40a3) — its approver must be an Archi/Dev who knows it is N1, not an approval on AI review alone; author ≠ approver.🤖 Generated with Claude Code