Repository navigation
Add DIALOG_CLICK quest type - #11
Open
kazotaruumc72 wants to merge 1 commit into
Open
kazotaruumc72 wants to merge 1 commit into
kazotaruumc72 wants to merge 1 commit into
Conversation
Progresses when a player clicks a button of a zMenu dialog, using zMenu's PlayerDialogClickEvent. The event is registered by reflection, so zQuests still works with zMenu versions that do not have it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New quest type
DIALOG_CLICK: progresses when a player clicks a button of a zMenu dialog.buttonis the key of the button in the dialog file: the key undermulti-actions,yes/nofor a confirmation dialog,notice,exit-button.Depends on
PlayerDialogClickEvent.The listener is registered by reflection (
PluginManager#registerEventon the class found by name), so this PR compiles against the currentzmenu-apiand zQuests keeps working with zMenu versions without the event: it just logs an info message andDIALOG_CLICKquests never progress. Once a zMenu release contains the event, the type works without any zQuests change. Cancelled events are ignored.Changes
QuestType.DIALOG_CLICK, API recordDialogClick(dialog, button)andDialogClickActionDialogClickAction/DialogClickQuestLoader(case-insensitive matching,*wildcard)DialogClickListener, registered inQuestsPlugin#onEnabledocs/configurations/quests.mdTest plan
./gradlew compileJavapasses🤖 Generated with Claude Code