Repository navigation
Update Sarah to 1.27 and zMenu API to 1.1.2.1 - #10
Open
kazotaruumc72 wants to merge 1 commit into
Open
kazotaruumc72 wants to merge 1 commit into
kazotaruumc72 wants to merge 1 commit into
Conversation
- Handle the new DatabaseType.POSTGRESQL with HikariDatabaseConnection - Since Sarah 1.27, select throws a DatabaseException instead of returning an empty list: catch and log it when loading a player, so the error is not lost in the executor and no empty user is loaded Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fr.maxlego08.sarah:sarah1.23 → 1.27 (latest release)fr.maxlego08.menu:zmenu-api1.1.1.6 → 1.1.2.1 (latest on repo.groupez.dev)Changes required by Sarah 1.27
DatabaseType.POSTGRESQL, which made theswitchinZStorageManager#loadDatabasenon-exhaustive (compile error). It is now handled withHikariDatabaseConnection. Note: the PostgreSQL JDBC driver is not shaded, so using it requires the driver on the server classpath.select/selectAll/countthrow aDatabaseExceptioninstead of returning an empty result.ZStorageManager#loadnow catches and logs it: otherwise the exception would be silently swallowed by the executor. On error, no emptyUserQuestis loaded, so player data is not overwritten.Test plan
./gradlew compileJavaand./gradlew shadowJarpass🤖 Generated with Claude Code