Skip to content

Give the inventory back when a clear-inventory menu opens an inventory without holder #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxlego08 merged 1 commit into from
Nov 12, 2026
Merged

Give the inventory back when a clear-inventory menu opens an inventory without holder #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Common/src/main/java/fr/maxlego08/menu/inventory/zinv/ZInventory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,8 @@ public void closeInventory(Player player, InventoryEngine inventoryDefault) {
menuPlugin.getScheduler().runAtEntityLater(player, task -> {
InventoryHolder newHolder = CompatibilityUtil.getTopInventory(player).getHolder();
boolean isInNewzMenuInventory = newHolder instanceof InventoryDefault;
if (newHolder != null && !(newHolder instanceof InventoryDefault)) {
// A null holder is still another inventory (InvUI windows, Bukkit.createInventory(null, ...)), not a zMenu one
if (!isInNewzMenuInventory) {

List<ItemStack> sessionItems = this.clearInventory && this.clearInvType != ClearInvType.PACKET_EVENT ? this.collectSessionItems(player, inventoryDefault) : Collections.emptyList();

Expand Down
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
* Added `ActionPlayerData#getScope`. `ZActionPlayerData` now takes the `MenuPlugin` and a `VariableScope`.
* Removed the legacy `ClassicMeta` formatter. zMenu always formats items, messages and titles with MiniMessage through `ComponentMeta`. If it cannot start, zMenu logs an error and disables itself. `enable-mini-message-format` now only controls Dialogs support.
* You must use zMenu+ to be able to use the hot reload.
* Fixed `clear-inventory` menus not giving the player's inventory back when they open an inventory without holder, such as an InvUI window or `Bukkit.createInventory(null, ...)`, from a menu: the player kept the `player-inventory` buttons as real items in place of their own items, until they reconnected or closed another menu with `clear-inventory`.

## New Features

Expand Down
Loading