Repository navigation
chore: modernize Go to 1.27 + smoke test - #10
Merged
Merged
Conversation
Coverage was 3.5% overall with zero tests in cmd/ (the webhook's patching logic). Adds a single smoke test covering getNodeName's happy/error paths and computeProportionalResourceRequirements, raising cmd coverage from 0% to 10.7%.
Go 1.23 fell out of the supported-release window; 1.27 is the latest supported major as of 2026-08. Updates .mise.toml, go.mod, and the Dockerfile builder image together, plus direct deps (ginkgo, gomega, zap, k8s.io/api, k8s.io/apimachinery, controller-runtime, golang-set). This pulls golang.org/x/net to v0.58.0 and golang.org/x/oauth2 to v0.36.0 transitively, exceeding the versions in the two open dependabot PRs (#9, #7) - those PRs are now superseded. Build and tests remain green; CI reads its Go version from go.mod (go-version-file), so no separate workflow change was needed.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
-- Claudelie