fix(cypher+write): anonymous nodes, edge variables, ActionReceipt everywhere - #27
Merged
Merged
Conversation
added 3 commits
September 8, 2026 11:12
VOR runs from a single call site (layer.py:1097); idle scheduler is call-gated and 2/3 idle tasks are dead stubs; 42 of 136 memory nodes hang without TTL since 2026-08-11. Cherry-picked onto current main; also drops a stray leftover conflict marker '>>>>>>> 86ef986d' from the previous KNOWN_ISSUES resolution (was merged into main via PR #25 unnoticed by check_known_issues).
Root cause: from_node_alias defaulted to n1 while joins used n{idx*2} for anonymous left nodes (no such column: n0.id); edge variable [e:] was dropped (alias hardcoded e{idx}), so e.type resolved to json_extract on a missing table. Fix: resolve from_node_alias to the generated alias; register edge vars in edge_vars and map e.type/source_id/target_id to columns; support count(e). 10 regression tests (SQL+E2E) + 5 Red Team attacks covered.
…onymous nodes
WriteTool._contract_record now emits an ActionReceipt alongside ChangeIntent via new _contract_receipt(); _contract_record itself was added to replace/insert/rename-LSP/move (incl. refs) paths that previously wrote files without any contract artifact.
Cypher engine (cypher_sql.py): resolve from_node_alias for anonymous nodes (n{path_idx*2}), register edge variables ([e:]) into edge_vars/edge_prop_map so e.type/source_id/target_id and count(e) translate to SQL.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three commits from the 2026-09-07 investigation, cherry-picked onto current origin/main.
fix(cypher): support anonymous nodes and edge variables
\MATCH ()-[e:ASSIGNED_FROM]->()\ previously failed with
o such column: e\ /
o such column: n0.id\ because:
1\ while joins used
{path_idx*2}\ for anonymous left nodes
Fix: resolve from_node_alias to the generated alias; register edge vars in edge_vars and map e.type/source_id/target_id to columns; support count(e). 10 regression tests (SQL+E2E) + 5 Red Team attacks covered.
fix(write): record ActionReceipt in all write paths
\WriteTool._contract_record\ now emits an ActionReceipt alongside ChangeIntent via new _contract_receipt(); _contract_record\ added to replace/insert/rename-LSP/move (incl. refs) paths that previously wrote files without any contract artifact. Receipt-write is warning-only, does not break write.
docs(memory): lazy-only verification gap
VOR runs from a single call site (layer.py:1097); idle scheduler is call-gated; 42 of 136 memory nodes hang without TTL since 2026-08-11. Experiment plan logged.
Also
Drops a stray leftover conflict marker '>>>>>>> 86ef986d' from KNOWN_ISSUES.md (survived into main via PR #25 unnoticed by check_known_issues).
Verification