Skip to content

[calendar] use the current CalendarLabs URL for the default calendar - #4347

Open
farisbasha wants to merge 1 commit into
MagicMirrorOrg:developfrom
farisbasha:fix-default-calendar-url
Open

farisbasha wants to merge 1 commit into
MagicMirrorOrg:developfrom
farisbasha:fix-default-calendar-url

Conversation

@farisbasha

Copy link
Copy Markdown
  • Does the pull request solve a related issue? No open issue.
  • What does the pull request accomplish?
    • The calendar module's built-in default (defaults.calendars[0].url in defaultmodules/calendar/calendar.js) still points to https://www.calendarlabs.com/templates/ical/US-Holidays.ics, which now returns 404. Anyone who adds the calendar module without a calendars entry gets a failing fetch.
    • CalendarLabs moved to per-project URLs (see Prevent too frequent request for sample ical #3137); config/config.js.sample already uses the MagicMirror one, https://ics.calendarlabs.com/76/mm3137/US_Holidays.ics (200). This makes the module default match the sample config.
    • One-line change; no visual changes.

I did not run the test suite locally (no install here), so CI is the check.

AI disclosure: prepared with an AI coding assistant (Claude).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant