Repository navigation
fix(cors): secure secret proxy requests - #4338
Merged
Merged
Conversation
khassel
approved these changes
Nov 9, 2026
Collaborator
|
@KristjanESPERANTO did you cancel the node v26 test? |
Collaborator
Author
|
It was cancelled because the v22 test failed before (because it couldn't download electron). I re-run the cancelled tests - all green now 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this CORS secret substitution is limited to explicitly configured host/secret pairs and secure HTTPS requests without redirects. Requests that do not use secrets retain their existing behavior.