Repository navigation
fix(logger): recognize callers on Windows - #4337
Merged
KristjanESPERANTO merged 1 commit intoNov 8, 2026
Merged
KristjanESPERANTO merged 1 commit into
KristjanESPERANTO merged 1 commit into
Conversation
KristjanESPERANTO
approved these changes
Nov 8, 2026
KristjanESPERANTO
left a comment
KristjanESPERANTO
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! 🙂
I don't have a windows system now to test it, but looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize path separators before filtering and reading stack frames. On Windows, the logger was treating its own frame as the caller and printing the logger path instead of the script or module name.
Verification
node --run lint:fixand checked the diff.AI assistance was used to implement and verify this change.