Repository navigation
fix(weather): preserve zero feels-like temperatures - #4336
Merged
KristjanESPERANTO merged 2 commits intoNov 9, 2026
Merged
KristjanESPERANTO merged 2 commits into
KristjanESPERANTO merged 2 commits into
Conversation
Collaborator
|
Looks good, thanks for the PR! 🙂 While tracing the data flow, I noticed a related issue in |
KristjanESPERANTO
approved these changes
Nov 9, 2026
Collaborator
|
@xunguangzlj-cloud Thanks for the additional commit! This will land in the next release 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A weather provider can report a feels-like temperature of exactly 0. Keep that reading instead of substituting a calculated value. The fallback for missing or invalid readings still works.
Verification
node --run lint:fixand checked the resulting diff.AI assistance was used to implement and verify this change.
Review follow-up: the UK Met Office provider now preserves 0°C in current observations, the first-hour fallback, daily forecasts, and hourly forecasts. All four regressions returned null on the previous head. The weather unit suite passed all 247 tests, and both changed files passed ESLint and Prettier.