You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tracking issue for the #1821 follow-ups, so the ordering is written down somewhere.
#1821 landed heterogeneous immersed-boundary surface chemistry as a single 2733-line change. It is reviewed and working, and splitting it retroactively would be churn — but the pieces inside it have different owners, different test strategies, and in one case a different repository.
Nothing else. The remaining ~1400 lines are an example, its mechanisms, generated goldens, and ordinary parameter plumbing. Those are the right size and in the right place — this is not an argument that Add heterogeneous reacting surface boundary conditions #1821 should have been four PRs.
Why bother
The two extractions are what make the feature independently testable. Codecov reports 56.97% patch coverage on #1821 with 55 uncovered lines in m_ibm.fpp; the solver and the codegen are precisely the parts currently reachable only through a full 2-D reacting simulation compared against a golden. Both have already produced bugs that unit tests would have caught cheaply (a sticking-coefficient rate emitted as plain Arrhenius; a sum-constraint closure landing on a trace radical).
Tracking issue for the #1821 follow-ups, so the ordering is written down somewhere.
#1821 landed heterogeneous immersed-boundary surface chemistry as a single 2733-line change. It is reviewed and working, and splitting it retroactively would be churn — but the pieces inside it have different owners, different test strategies, and in one case a different repository.
Where the lines are
input.py)m_ibm.fpp)m_ibm.fpp— correct as isexamples/— correct as isOrdering
Why bother
The two extractions are what make the feature independently testable. Codecov reports 56.97% patch coverage on #1821 with 55 uncovered lines in
m_ibm.fpp; the solver and the codegen are precisely the parts currently reachable only through a full 2-D reacting simulation compared against a golden. Both have already produced bugs that unit tests would have caught cheaply (a sticking-coefficient rate emitted as plain Arrhenius; a sum-constraint closure landing on a trace radical).No action needed on #1821 itself.