Repository navigation
PR commands: no false fails on branches behind main - #1810
Merged
Merged
Conversation
Two workflow bugs marked good runs as failed on PRs whose branch is behind main: - The --save dry run (and the merge in benchmark-pr.yml) fetched main with --depth=1 into a full-history checkout. That writes main's tip into .git/shallow, the merge-base disappears, and git refuses with "refusing to merge unrelated histories" - reported as "main has diverged". Every passing pre-check was "Already up to date"; it never tested for conflicts. Fetch without --depth. - benchmark-pr.yml runs from main but with the PR's scripts, and since #1777 it calls scripts/spec.sh after every full benchmark. A branch cut before #1777 has no spec.sh, so every entry was marked failed after benchmarking fine (#1758: Failed: 6). Skip the suites with a notice when the script is missing; a /spec run still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two workflow bugs marked good runs as failed on PRs whose branch is behind main. #1758 hit both.
--save. The dry run fetched main with--depth=1into a full-history checkout. That cuts main's tip off from its parents, so git refuses withrefusing to merge unrelated historiesfor any branch behind main. Every passing pre-check I sampled was "Already up to date", so it never actually tested for conflicts (fib v1.8.0, fib-tuned compression, go-stdlib HTTP/2, add quic-go #1758 merges main cleanly). Fixed by fetching without--depth, in 5 places. The lines match the same change in fix: update Tako to 2.7.1 and validate benchmark results #1762, so either PR merges cleanly after the other.scripts/spec.shafter every full benchmark. A branch cut before Compliance: a /spec route for the protocol-compliance suites, aspnet-minimal first #1777 doesn't have that script, so all six fib v1.8.0, fib-tuned compression, go-stdlib HTTP/2, add quic-go #1758 entries failed on./scripts/spec.sh: No such file or directory(run 43751778310). The suites are now skipped with a notice when the script is missing. A spec-only run on such a branch still fails.Tested:
--depthis dropped.Workflows run from main, so this takes effect once merged.
🤖 Generated with Claude Code