Repository navigation
ci: move from AppVeyor to GitHub Actions - #80
Merged
Merged
Conversation
AppVeyor and Codecov no longer report, so every PR waits forever on their required statuses. Build, test and pack on GitHub Actions instead, and publish to nuget.org through trusted publishing on a GitHub release. To build on the .NET 10 SDK: tests target net10.0 and net481, the vulnerable Newtonsoft.Json 11.0.2 (GHSA-5crp-9r3c-p9vr) goes to 13.0.4, and two tests call ToDictionary/Contains explicitly, which .NET 8 and C# 14 made ambiguous. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rducom
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppVeyor and Codecov no longer report on this repo, so every PR (e.g. #79) waits forever on the
continuous-integration/appveyor/pr,codecov/patchandcodecov/projectstatuses required bymaster's branch protection.This moves CI to GitHub Actions (
.github/workflows/ci.yml): build, test and pack on every PR and push, publish to nuget.org on a GitHub release (version = release tag). It runs on GitHub-hosted runners, not the Lucca self-hosted ones, because the repo is public.appveyor.yml,build.ps1and the dead badges go.To build on the .NET 10 SDK:
net10.0;net481instead ofnetcoreapp3.1;net461TreatWarningsAsErrorsturns that into a restore errorGenericExtensions.ToDictionaryandEnumerable.Containsexplicitly: .NET 8 added its ownToDictionary()for key/value pairs, and C# 14 bindsarray.Containsto the span overload226/226 tests pass on both targets locally.
After merge, an admin has to:
buildNExtends(repoLuccaSA/NExtends, workflowci.yml) and aNUGET_USERrepo secret, as on MerQure🤖 Generated with Claude Code