Repository navigation
feat: add a guard on the commits of Dependabot pull requests - #24
Merged
Merged
Conversation
The approval of a Dependabot pull request survives its next commits. This check fails when one of them does not come from the bot, or changes other paths than the expected ones.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The approval of a Dependabot pull request survives its next commits, which the auto-merge needs for the commits of the bot. This adds a check that limits what those commits can do.
Changes
check-bot-commitsaction: the first commit comes from Dependabot, and the next ones come from the bot and only change the given paths. It does nothing on another pull request.dependabot-commit-guard.ymlreusable workflow, meant to be a required check. It is called on every pull request, since a required check of a job skipped by the caller stays pending.Limit
The check relies on the commit author that GitHub reports. It raises the bar and limits the paths, but a token with write access could still rewrite the branch.
Test plan
check-bot-commitsCI job passes