Repository navigation
ci: deploy commons before other wikis - #8322
Merged
Merged
Conversation
Wikis depend on commons modules, so deploying commons first avoids a window where a wiki runs new code against an old commons module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the commons-first Lua deployment ordering change.
No open issues 🎉
What changed in this PR
Updates Lua deployment ordering so commons modules deploy before wiki-specific modules, reducing the window in which new wiki code runs against outdated shared modules.
Changes:
- Prioritizes commons paths before grouping files by wiki.
- Preserves alphabetical deployment order for the remaining wikis.
| File | Description |
|---|---|
scripts/deploy.py |
Adds a commons-first sort key to the Lua deployment loop. |
Review effort: Balanced
ElectricalBoy
changed the title
ElectricalBoy
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lua deploy now always deploys commons before the other wikis. Other wikis still deploy in alphabetical order. Before this, commons came after wikis like
apexlegendsandcallofduty. Those wikis could then run new code against old commons modules for a short time.How did you test this change?
Ran the new sort and grouping on sample paths from several wikis. Commons came out first, and the other wikis stayed alphabetical. The script also compiles. No live deploy was run.
🤖 Generated with Claude Code