Skip to content

feat(match2): automatically purge bracket page on matchpage change - #7198

Open
ElectricalBoy wants to merge 5 commits into
mainfrom
experimental-matchpage-autopurge
Open

ElectricalBoy wants to merge 5 commits into
mainfrom
experimental-matchpage-autopurge

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Member

Summary

This PR automates purging of tournament page when matchpage is saved.

How did you test this change?

dev + browser dev tools

@ElectricalBoy
ElectricalBoy requested a review from a team as a code owner March 3, 2026 12:35
@ElectricalBoy ElectricalBoy added the g: valorant VALORANT label Mar 3, 2026
@ElectricalBoy
ElectricalBoy requested a review from a team as a code owner March 3, 2026 12:35

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it wise to add this before we have lighthouse?

@ElectricalBoy

ElectricalBoy commented Mar 3, 2026 •

Copy link
Copy Markdown
Member Author

is it wise to add this before we have lighthouse?

check admin discord

@mbergen
mbergen requested a review from FO-nTTaX March 3, 2026 12:56
@FO-nTTaX

FO-nTTaX commented Mar 3, 2026

Copy link
Copy Markdown
Member

I'm slightly worried about people getting timed out for this, medium-term this is something we probably should do on the backend

@ElectricalBoy

Copy link
Copy Markdown
Member Author

I think it should be pretty safe from timeouts
purging via mw api would be triggered if you are logged in, working in Match: namespace, and made a (non-touch) save of matchpage

@Rathoz

Rathoz commented Mar 3, 2026

Copy link
Copy Markdown
Member

Agreed with FO

@Rathoz Rathoz removed the javascript label Jul 3, 2026
@ElectricalBoy
ElectricalBoy force-pushed the experimental-matchpage-autopurge branch from 9d49e1a to c2c8816 Compare November 3, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants