Repository navigation
Scan: RetroDECK is found wherever it is installed - #129
Merged
Merged
Conversation
RetroDECK's folder is always named retrodeck, but it goes wherever the user chose. The scan only looked in the default ~/retrodeck and at the top of an SD card, so a RetroDECK at ~/Games/Retrodeck/retrodeck, as a user had it, still turned up nothing. It now also looks one and two folders down in the home folder, and one more level down on an SD card.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #121. RetroDECK's folder is always named
retrodeck, but it goes wherever the user chose. #121 only looked in the default~/retrodeck/savesand at the top of an SD card, so a RetroDECK installed at~/Games/Retrodeck/retrodeck(the user who reported this on Discord) still turned up nothing.The scan now also looks in:
~/*/retrodeck/savesand~/*/*/retrodeck/saves, one and two folders down in the home folder;/run/media/*/*/*/retrodeck/saves, one more level down on an SD card.The folder layout inside
saves(one folder per system) matches what #121 expects; the reporter's listing confirmed it.Test:
TestRetroDECKDetection_ChosenFolder, with the reporter's layout. It fails without this change.